dogweather
A nice way to combine captured functions? (Credo.Check.Refactor.RejectReject)
This code generates a couple of Credo warnings:
filtered_paragraphs =
paragraphs
|> Floki.filter_out("[align=center]")
|> Enum.reject(&repealed?/1)
|> Enum.reject(&subchapter_heading?/1)
|> Enum.reject(&subsubchapter_heading?/1)
One
Enum.reject/2is more efficient thanEnum.reject/2 |> Enum.reject/2(refactor:Credo.Check.Refactor.RejectReject)
Is there some expressive way to combine these three rejects with a logical or?
Is refactoring the best answer, extracting them into a single new named function that I use with reject? Are there any function-level tools for working with captured functions?
Maybe a reject_any? function would be good here.
Marked As Solved
Marcus
You could do something like this:
filtered_paragraphs =
paragraphs
|> Floki.filter_out("[align=center]")
|> Enum.reject(&(repealed?(&1) or subchapter_heading?(&1) or subsubchapter_heading(&1)))
Also Liked
trisolaran
Floki keeps things in memory as a list - when dealing with stuff that is already stored in memory, the Stream API only brings a performance penalty (it’s slower) with no additional memory savings (stuff is already in memory, so there’s no advantage in consuming it lazily).
If you want to use Stream effectively in this use case you will need to generate your paragraphs lazily.
tcoopman
Is this code on a performance critical path? If not, I would keep the code like it is now. It’s very readable.
sodapopcan
If you change it to Stream.reject does it complain? If you know it’s going to be a small input then what you have is clearly no big deal. Personally I would go either the named function route or a string of ors in the fn body or I would just disable linting for that line if I know the input is always going to be small (but guh, that does suck!)
Popular in Questions
Other popular topics
Latest on Elixir Forum
Sponsor Spotlight
Catch errors, track performance, monitor hosts and more.
Categories:
Sub Categories:
Forums
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Develop your skills with books, videos, and courses.
Producing high quality Elixir screencasts since 2017.
Enabling companies to succeed by building software people love.
Courses that'll move you from confusion to "Aha, now I get it!"