thojanssens1
Better way to get default option?
I have something like:
Keyword.get(
opts,
:upload_path_changer,
Application.get_env(
:file_uploader,
:upload_path_changer,
MyApp.UploadPathChanger
)
)
Get the :upload_path_changer module from options (opts);
if not found in options, get it from the config file;
if not found in the config file, use MyApp.UploadPathChanger.
Do you think the code above can improve in readability?
Most Liked
dimitarvp
Just make a helper in one of your modules. I also found such snippets very tiresome and just hid the complexity away in neat quick functions.
hauleth
This will change semantics of the original, as opts = [upload_path_changer: nil] will return different results in original and this one.
Maybe merge options with defaults?
default_opts = [
upload_patch_changer: Application.get_env(:file_uploader, :upload_patch_changer, MyApp.UploadPatchChanger)
# other options if needed
]
opts = Keyword.merge(default_opts, opts)
NobbZ
Something like this?
Keyword.get(opts, :upload_path_changer) || Application.get_env(:file_uploader, :upload_path_changer) || MyApp.UploadPathChager
Kurisu
I really like this approach, especially when there are several default options. ^^
Popular in Questions
Other popular topics
Latest on Elixir Forum
Sponsor Spotlight
Catch errors, track performance, monitor hosts and more.
Categories:
Sub Categories:
Forums
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Practical resources that improve the lives of professional developers.
Producing high quality Elixir screencasts since 2017.
Enabling companies to succeed by building software people love.
Courses that'll move you from confusion to "Aha, now I get it!"