Qqwy

Qqwy

TypeCheck Core Team

Ecto.Query.update dynamic field name

I am working on a library that allows re-ordering rows of an Ecto schema based on an integer column.

Right now, the column is hard-coded to always be :position. Of course, this should become configureable.

However, the code contains statements such as the following:

    |> Ecto.Multi.update_all(:decremented_higher_siblings_1, from( p in later_siblings, update: [set: [position: fragment("- (? - 1)", p.position)]]), []).

Note here the update: [set: ...] part (see the documentation of Ecto.Query.update.

I know Ecto.Query.field exists to set a dynamic field name, but as update uses a keyword list, I have no idea how to properly set the keyword list key there (as the line still is supposed to be read as macro, with the p variable available).

How to do this?

Marked As Solved

prem-prakash

prem-prakash

I could do that like this:

     update_args = Keyword.new([{f, new}])

     from(
       a in table,
       update: [set: ^update_args],
       where: field(a, ^f) == ^old
     )
     |> MyApp.Repo.update_all([])

Also Liked

halostatue

halostatue

For people, like me, who need this to be sort-of generalized, the following MOSTLY works. It turns out that I needed to do {:replace, columns} rather than :replace_all_except_primary_key because my input data was not including that, so there’s some behind the scenes stuff coming in Ecto 3.0 which will make this very clean, but this will generalize this in the short term.

defmodule ConflictUpdate do
  @moduledoc """
  A function to create an update query for an `on_conflict:` clause in
  `insert_all`.
  """

  @doc "A function to create an update query for a schema."
  @spec conflict_update(Ecto.Schema.t(), :replace_all | :replace_all_except_primary_key |
                               {:replace, list(atom)}) :: Macro.t()
  defmacro conflict_update(schema, pattern) do
    e_schema = Macro.expand_once(schema, __CALLER__)
    e_pattern = Macro.expand_once(pattern, __CALLER__)

    update_args =
      e_schema
      |> columns(e_pattern)
      |> Enum.map(& {&1, {:fragment, [], ["EXCLUDED.#{&1}"]}})
      |> Keyword.new

    {:update, [context: Elixir, import: Ecto.Query],
      [
        schema,
        [
          set: update_args
        ]
      ]
    }
  end

  defp columns(schema, :replace_all), do: schema.__schema__(:fields)

  defp columns(schema, :replace_all_except_primary_key),
  do: schema.__schema__(:fields) -- schema.__schema__(:primary_key)

  defp columns(_schema, {:replace, fields}), do: fields
end
Qqwy

Qqwy

TypeCheck Core Team

Wonderful! Thank you very much for solving this problem. :slight_smile:

Where Next?

Popular in Questions Top

sergio
In Ruby, I can go: User.find_by(email: "foobar@email.com").update(email: "hello@email.com") How can I do something similar in Elixir? ...
New
dotdotdotPaul
Okay, I'm having a heck of a time trying to figure out how to best handle the validation of belongs_to associations in Ecto. I'm sure I'...
New
pgiesin
This should be a simple problem but I just can’t seem to figure it out. I have a standalone Elixir app that won’t find the database. Dep...
New
jononomo
I am trying to figure out how Mix knows whether the environment is test, dev, or prod -- where is this set? Thanks.
New
script
If I have a string “1000 cfu/ml” . I want to remove the characters and / and space . So the string is like this "1000" What is the ...
New
vac
Hi, I'm quite new in Elixir and I'm trying to format a string to a PEM format. I have the certificate value like MIIDBTCCAe2...... and ...
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
qwerescape
Is there a way to get the call stack or stack trace at any point in the code? Not from exceptions, but an expression that returns how the...
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers' Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
joeerl
Hello again - after a longish gap I’ve decided I really must dig into Elixir and see what’s been happening here - so I have a few questio...
New

Other popular topics Top

srinivasu
How to handle excepions in elixir? Suppose i have A, B, C ,D, E modules. and each module has get() function. A.get() method will call th...
New
dotdotdotPaul
Okay, I'm having a heck of a time trying to figure out how to best handle the validation of belongs_to associations in Ecto. I'm sure I'...
New
lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
KronicDeth
Elixir plugin for JetBrain’s IntelliJ Platform (including Rubymine) This is a plugin that adds support for Elixir to JetBrains IntelliJ...
289 35421 110
New
SoCreat
i’m a new one to elixir which editor can i use vs code? or atom? Thanks! :smiley:
New
chrismccord
This release brings a number of exciting features, including integration with the new Phoenix LiveDashboard and Phoenix LiveView. There h...
New
mgjohns61585
Could someone help me? I'm making my first elixir program, number guessing game. I can't figure out how to convert the user's guess from ...
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID<0.412.0> terminating ** (Postgrex.Error) FATAL...
New
romenigld
I am trying to run a deploy with docker and I successfully runned with this command: docker build -t romenigld/blog-prod . but when I t...
New
siddhant3030
Hi, I have to write a raw query for one of my project. But till now I have used ecto queries and don’t have much experience writing raw ...
New

We're in Beta

About us Mission Statement