niels_bom
Idiomatic: pattern matching with two function heads or boolean guard clause?
I just found myself writing this:
def foo([], _), do: []
def foo(_, 0), do: []
But then I thought I could also use a guard clause with a boolean OR, like so:
def foo(list, n) when list == [] or n == 0, do: []
Is either version more idiomatic?
Would it maybe depend on the amount of code in the function? (DRY and all)
Because pattern matching is so nice and in this case the function body is very small I’ll probably choose the first version.
Thanks!
Most Liked
NobbZ
The first one, as it leaves more room for optimisation by the compiler. Also matching 0 in the function head is more strict than x == 0 since 0.0 == 0.
PS: sometimes, if from business perspective both cases are to treat the same and not only by accident, I tend to use a guard using ===, as it better communicates indent of treating this cases the same.
dimitarvp
I use both of these idioms – and others – quite often. My main heuristic is: “is the code readable?”
The only non-idiomatic Elixir in such cases would be a load of if-s. The rest is quite fine and the exact idiom should vary depending on your priorities and the situation.
Popular in Questions
Other popular topics
Latest on Elixir Forum
Sponsor Spotlight
Catch errors, track performance, monitor hosts and more.
Categories:
Sub Categories:
Forums
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Producing high quality Elixir screencasts since 2017.
Enabling companies to succeed by building software people love.
The deployment platform built for Elixir: PaaS ease, VPS control.
Courses that'll move you from confusion to "Aha, now I get it!"