scottming

scottming

Is there a way to write a do_not match guard for map match?

I have some complex business logic have to verify a input map. And I don’t want to use nested control-flow. I expect a not_match guard to this things.

defmodule ElixirFun do
  @moduledoc """
  Documentation for ElixirFun.
  """

  @doc """
  Hello world.

  ## Examples

      iex> ElixirFun.hello()
      :world

  """
  def hello do
    :world
  end

  def hello(%{a: a, b: b}) do
    # match a and b
    IO.puts "Hello #{a}, #{b}"
  end

  def hello(%{a: a}) when not_match(%{b: _}) do
    # match a and do not match b
    IO.puts "Hello #{a}"
  end

  def hello{%{b: b}} when not_match(%{a: _}) do
    # match b and do not match a
    IO.puts "Hello #{b}"
  end

  def hello(%{} = params) do
    # others
    IO.inspect(params)
  end
end

I have read all of elixir tips and tried

defguard key_c_is_nil(params) when is_map(params) and get_in(params, [:b]) == nil

but it doesn’t work.

Marked As Solved

peerreynders

peerreynders

It just works without it - as long as you put everything in the right order.

defmodule ElixirFun do
  def hello(%{a: _a, b: _b} = m),
    do: IO.puts("1: #{inspect(m)}")

  def hello(%{a: _a} = m),
    do: IO.puts("2: #{inspect(m)}")

  def hello(%{b: _b} = m),
    do: IO.puts("3: #{inspect(m)}")

  def hello(%{} = m),
    do: IO.puts("4: #{inspect(m)}")
end

ElixirFun.hello(%{a: 1, b: 2, c: 3})
ElixirFun.hello(%{a: 4, c: 5})
ElixirFun.hello(%{b: 6, c: 7})
ElixirFun.hello(%{c: 8})
ElixirFun.hello(%{a: nil, b: nil, c: 9})
ElixirFun.hello(%{a: nil, c: 10})
ElixirFun.hello(%{b: nil, c: 11})
 elixir elixir_fun.exs
1: %{a: 1, b: 2, c: 3}
2: %{a: 4, c: 5}
3: %{b: 6, c: 7}
4: %{c: 8}
1: %{a: nil, b: nil, c: 9}
2: %{a: nil, c: 10}
3: %{b: nil, c: 11}

… keeping in mind that those four clauses all belong to one and the same hello/1 function.

It might as well be:

defmodule ElixirFun do
  def hello(m) do
    case m do
      %{a: _, b: _} ->
        IO.puts("1: #{inspect(m)}")

      %{a: _} ->
        IO.puts("2: #{inspect(m)}")

      %{b: _} ->
        IO.puts("3: #{inspect(m)}")

      %{} ->
        IO.puts("4: #{inspect(m)}")
    end
  end
end

Also Liked

peerreynders

peerreynders

In my view multiple function clauses are preferred because it chunks the logic into distinct, separate logical paths even if they do belong to the same function. With case do you are dealing with one monolithic piece of code which gets worse the more cases you add - apart from the temptation to put code before and after the case do expression.

But that’s not to say that case do is to be avoided - they both have their place. Coming from more traditional programming languages one would tend to gravitate towards case do because it’s reminiscent of switch while pattern matching in function heads just seems weird - but in most cases with exposure people come to prefer pattern matching in function heads because of the clean separation it brings.

For some more background:

And for completeness a multi-clause anonymous function:

defmodule ElixirFun do
  def make_hello() do
    fn
      %{a: _, b: _} = m ->
        IO.puts("1: #{inspect(m)}")

      %{a: _} = m ->
        IO.puts("2: #{inspect(m)}")

      %{b: _} = m ->
        IO.puts("3: #{inspect(m)}")

      %{} = m ->
        IO.puts("4: #{inspect(m)}")
    end
  end
end

hello = ElixirFun.make_hello()
hello.(%{a: 1, b: 2, c: 3})
hello.(%{a: 4, c: 5})
hello.(%{b: 6, c: 7})
hello.(%{c: 8})
hello.(%{a: nil, b: nil, c: 9})
hello.(%{a: nil, c: 10})
hello.(%{b: nil, c: 11})
axelson

axelson

Scenic Core Team

These clauses seem like they’ll do what you want:

  def hello(%{a: a, b: b}) do
  def hello(%{a: a}) do ...
  def hello(%{b: b} do ...
  def hello(%{} = params) do

Unless there’s something I’m missing? Don’t forget that function clauses are checked top to bottom (eliding some compiler optimizations)

Edit: thought if you wanted to ensure not nil then I would add a when not is_nil(a) and when not is_nil(b) to each clause (based on the binding it is using).

scottming

scottming

Thank you both.

Where Next?

Popular in Questions Top

Brian
What is the proper way to load a module from a file in to IEX? In the python world, doing something like this pretty standard: from ....
New
senggen
Erlang/OTP 25 [erts-13.2.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] 15:22:35.803 [error] gen_event {lager_file_backend...
New
Tee
can someone please explain to me how Enum.reduce works with maps
New
pmjoe
I have a relationship of love and hate with Elixir. Lots of things are just absolutely right, but there are some things that are kind of ...
New
itssasanka
Hi all, Trying to get some more clarity over utc_datetime and naive_datetime for Ecto: https://hexdocs.pm/ecto/Ecto.Schema.html#module-...
New
pgiesin
This should be a simple problem but I just can’t seem to figure it out. I have a standalone Elixir app that won’t find the database. Dep...
New
fireproofsocks
I’m working on defining a simple Ecto schema for a table (in PostGres), but I don’t see where I can define a column as NOT NULL. Conside...
New
script
If I have a string “1000 cfu/ml” . I want to remove the characters and / and space . So the string is like this "1000" What is the ...
New
mgjohns61585
Could someone help me? I'm making my first elixir program, number guessing game. I can't figure out how to convert the user's guess from ...
New
chewm
Hi guys, nice to meet you to the whole forum, I’m new here, I’m trying to configure visual studio code for elixir, right now the intellis...
New

Other popular topics Top

Qqwy
Update: How to use the Blogs & Podcasts section You can post links to your blog posts or podcasts either in one of the Official Blog...
3268 119930 1237
New
William
I would like to know that is there any online source for learning Phoenix Framework for building E-Commerce Store? Any advantage on build...
New
bsollish-terakeet
Credo is smart enough to check for (something like) this: assert length(the_list) == 0 with this response: Checking if an enum is empt...
New
JorisKok
I have a server on AWS, and was running a load test using artillery. When looking at the Phoenix dashboard I see the Ports going to 100% ...
New
albydarned
Hello all! I am typing this post from my new MacBook Pro with the M1 chip. I’m loving it so far, and will probably use it as my daily dr...
New
joaquinalcerro
Hi there, I am working with Ecto-Postgresql and I need to call all of the records from a specific table but the table has 40,000 record...
New
axelson
This post is a wiki (feel free to hit the edit button near the bottom right of this post to add your own changes!) This post collects co...
239 45766 226
New
ovidiubadita
Hey all, I discovered Elixir and I love it. I always wanted to learn a functional programming and I intended to go for Haskell, but afte...
New
AstonJ
by Lance Halvorsen Elixir and Phoenix are generating tremendous excitement as an unbeatable platform for building modern web application...
460 27162 124
New
Nvim
Elixir appears to be a superior language to Python. I don’t see any advantage of Python over Elixir. Are there any?
New

We're in Beta

About us Mission Statement