sergio

sergio

Refactor tips for simple function for more idiomatic Elixir

I’d love for Ecto.Repo.get or get_by to return a {:ok, foobar} tuples. I could use it in with conditionals for cleaner more idiomatic Elixir.

Here’s my function:

def can_list_bots?(team_id, user_id) do
  team = Repo.get(Team, team_id)
  user = Repo.get_by(User, id: user_id, team_id: team_id)

  if team != nil && user != nil do
    "admin" in user.roles
  else
    false
  end
end

Is there any way to make this code more idiomatic that I’m not seeing?

Thanks for the tips!

Marked As Solved

idi527

idi527

Maybe

def can_list_bots?(team_id, user_id) do
  team = Repo.get(Team, team_id)
  user = team && Repo.get_by(User, id: user_id, team_id: team_id)

  if user do
    "admin" in user.roles
  else
    false
  end
end

or if you want with

def can_list_bots?(team_id, user_id) do
  with team when not is_nil(team) <- Repo.get(Team, team_id),
       user when not is_nil(user) <- Repo.get_by(User, id: user_id, team_id: team_id) do
    "admin" in user.roles
  else
    _ -> false
  end
end

or with with pattern matches

def can_list_bots?(team_id, user_id) do
  with %Team{} <- Repo.get(Team, team_id),
       %User{roles: roles} <- Repo.get_by(User, id: user_id, team_id: team_id) do
    "admin" in roles
  else
    _ -> false
  end
end

You can also do it in a single sql query. Probably.

Also Liked

peerreynders

peerreynders

with/1 can use guards

team when team != nil <- Repo.get(Team, team_id)
aptinio

aptinio

Haven’t tried it but maybe this single query could work:

Repo.one(from u in User,
  where u.team_id == ^team_id,
  where u.id == ^user_id,
  where "admin" == fragment("ANY (?)", u.roles)
)

Where Next?

Popular in Questions Top

JDanielMartinez
Hi! May someone helps me, please! I have two apps into an umbrella project: the first one is Database, which manages queries, and the se...
New
vonH
In asking this question I am more interested about the expressiveness of the language itself and less concerned about the availability of...
New
tduccuong
Hi, is there any work on GUI with Elixir, that is similar to Electron/Javascript? My idea is to bundle Phoenix and BEAM into a single se...
New
dokuzbir
Hello, I am trying to convert my lists to string without losing brackets.For start i have 3 map. They look like these buyer = %{ id: ...
New
hariharasudhan94
I would like to know what is the best IDE for elixir development?
New
vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
freewebwithme
Using vs code and installed ElixirLS: support and debugger. And I got an error popped up on start up says Failed to run ‘elixir’ comma...
New
shahryarjb
Hello, I have map which I want to convert it to string like this: the map: %{last_name: "tavakkoli", name: "shahryar"} the string I ne...
New
stefanluptak
Hello everybody, usually, I use a 29" ultra-wide monitor for VSCode which can easily accomodate explorer (files panel) + file with code ...
New
lanycrost
Hi everyone! I need implement if…else if…else condition from my elixir code, and anymore of this control flow structures not work proper...
New

Other popular topics Top

JDanielMartinez
Hi! May someone helps me, please! I have two apps into an umbrella project: the first one is Database, which manages queries, and the se...
New
senggen
Erlang/OTP 25 [erts-13.2.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] 15:22:35.803 [error] gen_event {lager_file_backend...
New
Tee
can someone please explain to me how Enum.reduce works with maps
New
quazar
How to set Jason to encode all fields in ecto schema, I don’t care about security and implementing only is taking long list of attributes...
New
polypush135
As many of you may have realized by now (sorry for all the posts here) I’ve been working on a db problem where I’m trying to aggregate a ...
New
aadeshere1
I have a another noob question about loop. Since elixir is immutable, while loop is not directly possible. total = 10 while total != 0 ...
New
msaraiva
Surface is an experimental library built on top of Phoenix LiveView and its new LiveComponent API that aims to provide a more declarative...
564 42633 214
New
chrisalley
ExUnit now has describe blocks which is a welcome addition coming from RSpec. In the docs, it states that nested hierarchies of describe ...
New
aesmail
Hello guys, I have finally made it. I created an admin interface for a framework. It’s been on my todo list for years and with the curre...
New
joeerl
Hello again - after a longish gap I’ve decided I really must dig into Elixir and see what’s been happening here - so I have a few questio...
New

We're in Beta

About us Mission Statement