I’d add a guard is_integer(team_id) as any non numeric type is greater than 0.

Also, I’d use string interpolation rather than inspect.

Inspection in general is something I’d only use for logging, never to create a user facing string.

You might use

defp get_url(0) do ...

This is not required. And if you really want to put a verb in there, get is about as vague as you can be, since it means so many different things . Using a verb like get or fetch as part of a function name would make more sense if you retrieve the URL value from somewhere else. In this case, where it is something the function itself calculates, I would just leave it out:

defmodule Team do
  def url(team_id) do
    ...
  end
end

Here, it is clear that Team.url(foo) will return an URL based on foo that has to do with a ‘Team’.

Of course, naming things quickly enters the realms of personal preference. It is very easy to spend all afternoon bikeshedding about it. It’s possibly the least important suggestion of all of the suggestions that people have given in this topic .

I’d probably just make:

defp get_url(id) when is_integer(id) and id >=0 do
  "a_url_removed_because_not_public#{if(id > 0, do: id)}"
end

Or more readably as (since I like to pull out arg calculations onto their own lines:

defp get_url(id) when is_integer(id) and id >=0 do
  sid = if(id > 0, do: id, else: nil)
  "a_url_removed_because_not_public#{sid}"
end