prateek1192

prateek1192

Creating a supervisor with multiple children

I am trying to take an input from the user and then creating the number of genservers as input and Supervise them. My code is something like

defmodule GossSim do
  use Supervisor

def main(args) do
  # Since it is a mix generated project I had to put the main
  Supervisor.start_link(__MODULE__, args)
end

def start_link(args) do
  Supervisor.start_link(__MODULE__, args)
end

#The two methods down below create children dynamically
def get_child_list(child_list, 0), do: child_list

def get_child_list(child_list, num_of_nodes) do
  child = 
    %{  
    id: :rand.uniform(num_of_nodes*100000),
    start: {Gossip_node, :start_link, [[0,true]]}
  }  
  if num_of_nodes > 0 do
   
    get_child_list( [child] ++ child_list, num_of_nodes-1)
  end
end

def init(args) do
  children = get_child_list([], 10)
  # The outut of this inspect is pasted below
  IO.inspect children, label: "The children list is"
  // some function that does something parse_args_and_start(args)
  // num_of_nodes is 10
  children = get_child_list([], num_of_nodes)
  Supervisor.init(children, strategy: :simple_one_for_one)

end

I get the following error
bad child specification, invalid children: [%{id: 83303, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 186070, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 85483, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 40851, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 85216, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 390428, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 466922, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 187412, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 103750, start: {Gossip_node, :start_link, [[0, true]]}}, %{id: 176391, start: {Gossip_node, :start_link, [[0, true]]}}]

The Supervisor doc says that a supervisor is fine if it has a start and an id. Since children is a list I am adding multiple maps of children in it. Am i missing something. Gossip_node is a module in the same folder.

Marked As Solved

rvirding

rvirding

Creator of Erlang

In one sense these are not really dynamic children. Yes, we are starting input specified number of children but from the supervisors POV it is starting the children all at start-up time so they are not dynamic. They could just as well be specified as a list of children to start.

Also there are no problems with dynamically starting children in a “normal” Supervisor. There is a Supervisor.start_child/2 which does this. This is the same as for DynamicSupervisor which also has a DynamicSupervisor.start_child/2. Both these functions need a child-spec. The main difference is how the children are terminated: in a Supervisor they are terminated in reverse order to which they were started; while in a DynamicSupervisor they are all terminated at the same time.

:simple_one_for_one is/was slightly different in that when you started the supervisor you gave one child spec which is then used as a template for all the children started/managed by it. It is/was a special case for running lots of the same thing.

Both Supervisor and DynamicSupervisor have a terminate_chlid/2 for killing children.

Also Liked

prateek1192

prateek1192

Thanks for looking into it @kokolegorille
I started looking into that but then they say that

The Supervisor module was designed to handle mostly static children that are started in the given order when the supervisor starts. A DynamicSupervisor starts with no children. Instead, children are started on demand via start_child/2

I don’t need to start children on demand. When my supervisor starts up it knows what processes it needs to supervise. Anyways with that Dynamic Supervisor too I might have run into the same error when trying to supervise multiple children as I would have tried to add them into the list.

rvirding

rvirding

Creator of Erlang

In this case :one_for_one would be the best choice, although that will probably not fix this error.

Where Next?

Popular in Questions Top

lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
jerry
Good day to you all. I have been struggling to get a query involving like and ilike to work. Can anyone assist me on this, please? pro...
New
sergio_101
I am VERY much an elixir newbie. I have taken one elixir course and one phoenix course on Udemy. During that course, I saw the instructor...
New
Kagamiiiii
Student & New to elixir. Nice language. I want to convert a english character, e.g. “a”, which is stored in a variable, to it’s asci...
New
Phillipp
Hey, I have a NanoPi-M3 and try to install Elixir on their Ubuntu image. I followed the Raspberry Pi installation instructions from the ...
New
aadeshere1
I have a another noob question about loop. Since elixir is immutable, while loop is not directly possible. total = 10 while total != 0 ...
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers' Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
lucidguppy
I have a super simple question about elixir - how would I take a file like this foo bar baz and output a new file that enumerates th...
New
siddhant3030
Hi, I have to write a raw query for one of my project. But till now I have used ecto queries and don’t have much experience writing raw ...
New

Other popular topics Top

JakeBecker
TL;DR: I’ve just released an implementation of Microsoft’s IDE-independent Language Server Protocol for Elixir. It adds language support ...
1140 51847 244
New
yawaramin
In the Dialyzer docs ( http://erlang.org/doc/man/dialyzer.html#requesting-or-suppressing-warnings-in-source-files ), there is a way to tu...
New
ycv005
I have followed this StackOverflow post to install the specific version of Erlang. And When I am running mix ecto.setup then getting fol...
New
jononomo
I am trying to figure out how Mix knows whether the environment is test, dev, or prod -- where is this set? Thanks.
New
mcarvalho
What is the difference between System.get_env and Application.get_env? For example, what are best practices to use one versus another.
New
aadeshere1
I have a another noob question about loop. Since elixir is immutable, while loop is not directly possible. total = 10 while total != 0 ...
New
rms.mrcs
Hi, I need to transform a list of numbers into a map where the keys are the indexes and the values are the original values of the list....
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID<0.412.0> terminating ** (Postgrex.Error) FATAL...
New
lucidguppy
I have a super simple question about elixir - how would I take a file like this foo bar baz and output a new file that enumerates th...
New
joeerl
Hello again - after a longish gap I’ve decided I really must dig into Elixir and see what’s been happening here - so I have a few questio...
New

We're in Beta

About us Mission Statement