Deveh

Deveh

Dialyzer (dialyxir) unmatched_return warning

So, I’m writing my home project with Elixir, everything’s going fine, decided to plug dialyxir to scan for some potential issues and it gives me this one error:

lib/http_server.ex:60:unmatched_return
The expression produces a value of type:

:ok | pid()

but this value is unmatched.

Code in question:

  defp accept_loop(listen_socket, %State{} = state) do
    state = %{state | total_calls: state.total_calls + 1}

    case :gen_tcp.accept(listen_socket) do # LINE 60, issue is here
      {:ok, client_socket} ->
        spawn(fn -> serve(client_socket, state) end)

      {:error, data} ->
        Logger.notice("Error accepting client socket - #{inspect(data)}")
    end

    accept_loop(listen_socket, state)
  end

Error about unmatched value from gen_tcp.accept. Everything’s working fine and according to documentation I’m matching values just fine - Erlang -- gen_tcp :

accept(ListenSocket) -> {ok, Socket} | {error, Reason}

I am matching both {:ok, socket} and {:error, reason} so I am at a loss now. What is going on?

Tried adding guard to :ok match - {:ok, client_socket} when is_port(client_socket) -> but mix dialyzer still returns same error.

Tried capturing first variable and checking whether it’s :ok or a pid - {test, client_socket} when test == :ok or is_pid(test) - still same error.

Marked As Solved

Deveh

Deveh

Ah, I see.

It’s the case statement itself that returns either pid from first match - spawn is called - or :ok from second match - Logger.notice call - and THAT is unmatched. So, with this insight, this is an easy “”“fix”"", as I don’t give a damn about what case returns.

  defp accept_loop(listen_socket, %State{} = state) do
    state = %{state | total_calls: state.total_calls + 1}

    _ = case :gen_tcp.accept(listen_socket) do
      {:ok, client_socket} ->
        spawn(fn -> serve(client_socket, state) end)

      {:error, data} ->
        Logger.notice("Error accepting client socket - #{inspect(data)}")
    end

    accept_loop(listen_socket, state)
  end

Also Liked

BartOtten

BartOtten

Sorry, can’t give you a solution. But maybe this might help. If not, you still learned some valuable lessons.

I once stumbled upon a blog post
https://medium.com/erlang-battleground/help-dialyzer-help-you-94db66bfbc5a.

The blog post mentions the next video which helps me ‘think like dialyzer’ and so find solutions.

But before anything, remove your dialyzer cache. Lesson learned the hard way. See:

Where Next?

Popular in Questions Top

Brian
What is the proper way to load a module from a file in to IEX? In the python world, doing something like this pretty standard: from ....
New
gshaw
What is the idiomatic way of matching for not nil in Elixir? E.g., First way: defp halt_if_not_signed_in(conn, signed_in_account) when...
New
Jim
As a follow up to my earlier question: I have the code compiling and running but not getting a successful login from the rest server. ...
New
sacepums
Hey guys. I'm new to elixir and im really stocked about it. But I ran into a bit of problem - I need to convert a date sting, for examp...
New
vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
aadeshere1
I have a another noob question about loop. Since elixir is immutable, while loop is not directly possible. total = 10 while total != 0 ...
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
vonH
When I run the Plug and I recompile I wind up having to use Ctrl C to quit iex and start again. Witht the help of rlwrap I can use the cu...
New
LegitStack
I’m trying to make a websocket server in Phoenix or raw Elixir. I heard about gun, I think I could use cowboy, but since I’m not that sma...
New
Codball
Mix format works fine if run from the cmd. I’ve followed this to facilitate the implementation into VSC which involves downloading an ext...
New

Other popular topics Top

senggen
Erlang/OTP 25 [erts-13.2.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] 15:22:35.803 [error] gen_event {lager_file_backend...
New
pmjoe
I have a relationship of love and hate with Elixir. Lots of things are just absolutely right, but there are some things that are kind of ...
New
William
I would like to know that is there any online source for learning Phoenix Framework for building E-Commerce Store? Any advantage on build...
New
JorisKok
I have a server on AWS, and was running a load test using artillery. When looking at the Phoenix dashboard I see the Ports going to 100% ...
New
KronicDeth
Elixir plugin for JetBrain’s IntelliJ Platform (including Rubymine) This is a plugin that adds support for Elixir to JetBrains IntelliJ...
289 35421 110
New
Harrisonl
We have an ECS cluster with 4 services, where each task joins a single cluster, via discovery ECS discovery service. Currently when I de...
New
myronmarston
The Elixir Typespec docs show the following syntax for keyword lists in typespecs: # ... | [key: type] # keyword lis...
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New
jay1
Why is it that the mnesia database isn’t the most preferred database for use in Elixir/Phoenix?
New

We're in Beta

About us Mission Statement