You could use macros for this, but since it’s really just substituting a value for thing it’s not a great fit.

Macros are really powerful when you want a piece of code to generate multiple related functions / data, or code that depends on the whole module’s settings. For instance, the Ecto.Schema.schema macro generates __changeset__ and __schema__ functions after all the schema fields are defined along with setting many module attributes.

Because this:

defmodule FooBar.Thing1Resolver do
  use FooBar.Share, struct: FooBar.Thing1
  import FooBar.Creator

  defcreate(FooBar.Thing1)
end

is harder to read than this:

defmodule FooBar.Thing1Resolver do
   def new(args) do
    struct(FooBar.Thing1), args)
  end

  def create(args) do
    struct(FooBar.Thing1), args)
  end
end

For instance, it’s considerably less obvious the functions generated in Thing1Resolver in the first version are identical since their definitions are split among two modules and use arguments differently.

Another approach to consider: put as little code in the macro as possible and call out to the real implementation. This is part of what happens when you say use Ecto.Repo in your application:

defmodule FooBar.Share do
  defmacro __using__(opts) do
    struct_name = opts[:struct]

    quote do
      def new(args) do
        FooBar.Share.new(unquote(struct_name), args)
      end
    end
  end

  def new(struct_name, args) do
    struct(struct_name, args)
  end
end

defmodule Wat do
  use FooBar.Share, struct: Wat

  defstruct [:val]
end

Wat.new(val: 1)

Here the macro generates a function which adds in the argument passed to use but delegates all the functionality to a function defined on FooBar.Share. There’s a tiny compilation space/performance improvement since less AST is generated, and there’s less thinking about tricky things with unquote.

Why not just have a function that takes the type of struct? Something like

def get_generic(thing, args) do
  data = get_from_api(args)
  struct(thing, args)
end

Also note with this code you’re not using the API result for anything, and it’s essentially doing nothing, assuming there are no side effects from that API call.

You could adapt something like…

defmodule Demo do
  for x <- [1, 2, 3] do
    def unquote(String.to_atom("get_#{x}"))(), do: unquote(x)
  end
end

# then

iex> Demo.get_1
1
iex> Demo.get_2
2
iex> Demo.get_3
3

But it won’t work because You will have functions with same signature… You need to do a little bit more work, like pattern match in functions arguments.

BTW Your code won’t work for multiple reasons…

defmodule Thing1Resolver do
  # There is no way to distinguish signature
   def get_one(args) do
     # You define data, but don't use it
     # get_from_api => side effect!
     data = get_from_api(args)
     # I suppose args should be data
     struct(Thing1, args)
   end

  # As You see, distinction is only inside the function body.
  def get_one(args) do
    struct(Thing2, args)
  end
end

How to solve this? You could call get_from_api outside the function, and pass data as argument.

You could solve with…

defmodule Thing1Resolver do
  def get_one(thing, data), do: struct(thing, data)
end

# and call

data = get_from_api(args)
Thing1Resolver.get_one(any, data)

But if You look at this, well, get_one is just the same as calling struct

In theory you can do it that way, but it is not the right way. Or I don’t understand you right. Here is an example how things can work. Please note that this example is not good under several aspects.

defmodule FooBar.Thing1 do
  defstruct [val: nil, type: This.Is.Thing1]
end

defmodule FooBar.Thing2 do
  defstruct [val: nil, type: This.Is.Thing2]
end

defmodule FooBar.Share do
  defmacro __using__(opts) do

    quote do
      def new(args) do
        struct(unquote(opts[:struct]), args)
      end
    end
  end
end

defmodule FooBar.Creator do
  defmacro defcreate(thing) do
    quote do
      def create(args) do
        struct(unquote(thing), args)
      end
    end
  end
end

defmodule FooBar.Thing1Resolver do
  use FooBar.Share, struct: FooBar.Thing1
  import FooBar.Creator

  defcreate(FooBar.Thing1)
end

defmodule FooBar.Thing2Resolver do
  use FooBar.Share, struct: FooBar.Thing2
  import FooBar.Creator

  defcreate(FooBar.Thing2)
end

That can be used like:

iex(1)> FooBar.Thing1Resolver.new(val: 55)
%FooBar.Thing1{type: This.Is.Thing1, val: 55}
iex(2)> FooBar.Thing2Resolver.new(val: 44)
%FooBar.Thing2{type: This.Is.Thing2, val: 44}
iex(3)> FooBar.Thing1Resolver.create(val: 55)
%FooBar.Thing1{type: This.Is.Thing1, val: 55}
iex(4)> FooBar.Thing2Resolver.create(val: 55)
%FooBar.Thing2{type: This.Is.Thing2, val: 55}