sharkmyster

sharkmyster

How to perform bulk associations with ecto?

I’m working on a game app that has an answers table and a categories table. This relationship is many to many.

The admins for the app can add answers and categories individually using usual controller format. However, I want to create a way to bulk associate answers to categories. On a category page there is a textarea to receive a comma separated list of strings. Upon hitting submit, I want to achieve the following steps,

  • assess if any of the strings already exist as an answer
  • for any that do not exist, create an record in the answers table
  • for all the answers that were given, create the association in the join table

Here is my attempt.

  def put_answers_to_category(category, answers_string) do
    answers =
      answers_string
      |> parse_answers_string()
      |> find_existing_and_create_new()

    old_category =
      category
      |> Repo.preload(:answers)
      |> IO.inspect()

    category
    |> Ecto.Changeset.change()
    |> Ecto.Changeset.put_assoc(:answers, Enum.uniq(answers ++ old_category.answers))
    |> IO.inspect()
    |> Repo.update()
  end

  def parse_answers_string(answers_string) do
    answers_string
    |> String.split(",", trim: true)
    |> Enum.map(&String.trim/1)
    |> Enum.reject(&(&1 == ""))
  end

  def find_existing_and_create_new(answers_list) do
    existing_answers =
      Answer
      |> where([a], a.raw in ^answers_list)
      |> Repo.all()

    existing_answers_raw = Enum.map(existing_answers, & &1.raw)

    new_answers =
      answers_list
      |> Enum.filter(fn ans -> !Enum.member?(existing_answers_raw, ans) end)
      |> Enum.map(fn ans -> %{raw: ans} end)
      |> Enum.map(&create_answer/1)
      |> Enum.map(fn {:ok, answer} -> answer end)

    existing_answers ++ new_answers
  end

This seems to be working but I think it may be verbose/inefficient. I’ve read the docs around cast_assoc and put_assoc but I couldn’t quite find a better way. Is there a better/more efficient way to do this?

Marked As Solved

tfwright

tfwright

As far as Ecto goes, I think that your implementation is the proper way to approach updating a many_to_many. But that really just means using put_assoc with an array of the set of answer records you want the category changeset to have.

The rest of the complexity here comes from the bulk upsert on the answer text param, but changing that would require a different API design. For example, a more conventional many_to_many update would take the answer ids directly, requiring them to all already exist. For example, the FE could be upserting them individually as they are entered via another endpoint.

Don’t know enough about your requirements to comment on whether that would be better overall, but I would say that you lose a significant advantage of your current approach by creating the new answers in a separate DB transaction (AFAICT), which means if the category update never goes through for whatever reason (validation error) the new answers will still be around in your DB, which may be unexpected.

Where Next?

Popular in Questions Top

lastday4you
I wanted to check elixir version in phoenix because i found that my elixir is 1.5 but when i use Enum.chunk_by it said the function is un...
New
logicmason
Hi there, I'm working through my first release with elixir/phoenix. I've built a release with distillery and found that it crashes when I...
New
sergio
In Ruby, I can go: User.find_by(email: "foobar@email.com").update(email: "hello@email.com") How can I do something similar in Elixir? ...
New
vonH
In asking this question I am more interested about the expressiveness of the language itself and less concerned about the availability of...
New
hariharasudhan94
I would like to know what is the best IDE for elixir development?
New
chewm
Hi guys, nice to meet you to the whole forum, I’m new here, I’m trying to configure visual studio code for elixir, right now the intellis...
New
chrisalley
ExUnit now has describe blocks which is a welcome addition coming from RSpec. In the docs, it states that nested hierarchies of describe ...
New
beno
I will often find my self writing things similar to: case some_value do nil -> something() "" -> something() _ -> someth...
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers' Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
jay1
Why is it that the mnesia database isn’t the most preferred database for use in Elixir/Phoenix?
New

Other popular topics Top

Brian
What is the proper way to load a module from a file in to IEX? In the python world, doing something like this pretty standard: from ....
New
AstonJ
You’re a programmer, so you don’t need spoon feeding with the conventional drivel about “this is an integer.” No. You need to know what’s...
New
KronicDeth
Elixir plugin for JetBrain’s IntelliJ Platform (including Rubymine) This is a plugin that adds support for Elixir to JetBrains IntelliJ...
289 35421 110
New
chrismccord
As promised, the first release candidate of Phoenix 1.3.0 is out! This release focuses on code generators with improved project structure...
New
myronmarston
The Elixir Typespec docs show the following syntax for keyword lists in typespecs: # ... | [key: type] # keyword lis...
New
chensan
I have a User schema with a :from_id field set to type :string: defmodule TweetBot.Repo.Migrations.CreateUsers do use Ecto.Migration ...
New
alice
Hey, Just curious what are the main benefits of Elixir compared to Clojure? When is Elixir more useful than Clojure and vice versa? Th...
New
vonH
When I run the Plug and I recompile I wind up having to use Ctrl C to quit iex and start again. Witht the help of rlwrap I can use the cu...
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
aesmail
Hello guys, I have finally made it. I created an admin interface for a framework. It’s been on my todo list for years and with the curre...
New

We're in Beta

About us Mission Statement