kyde

kyde

Which approach is better having multiple `handle_call` callbacks when using `GenServer` behavior or using helper functions?

I have a module where am using GenServer. In this module the state is a list of items. The module exposes functions to filter these items according to various criteria.
My question is what is the best approach to solving this task. Would it be better to:

  1. Add multiple handle_call callbacks for each filter criterion.
  2. Use the list_items functions and then filter its return value using multiple helper functions instead of the multiple handle_call callbacks.

Here is a simple implementation of the first approach:

defmodule Repositories do
  use GenServer
  
 ## API
  def start_link(_opts) do
    .GenServer.start_link(__MODULE__, :ok)
  end

  def list_items(pid) do
    GenServer.call(pid, :list_items)
  end

  def filter_by_name(pid, repo_name) do
   GenServer.call(pid, {:filter_by_name, repo_name})
  end
  
  # Other APIs here for filtering by other criteria
   ....

  ## Server
  def init(:ok) do
    initial_repos = #Fetch initial repos.
    {:ok, initial_repos}
  end

 def handle_call({:filter_by_name, repo_name}, _from, state) do
   matching_repos = Enum.filter(state, fn repo -> String.equivalent?(repo.name, repo_name) end)

   {:reply, matching_repos, state}
 end

  def handle_call(:list_items, _from, state) do
    {:reply, state, state}
  end

  # Other callbacks here for handling calls to filter by the other various criteria
   ....
end

Here is a simple implementation of the second approach:

defmodule Repositories do
  use GenServer
  
 ## API
  def start_link(_opts) do
    .GenServer.start_link(__MODULE__, :ok)
  end

  def list_items(pid) do
    GenServer.call(pid, :list_items)
  end

  def filter_by_name(pid, repo_name) do
   pid
   |> list_items()
   |> Enum.filter(fn repo -> has_name?(repo.name, repo_name) end)
  end
  
  # Other APIs here for filtering by other criteria
   ....

  ## Server
  def init(:ok) do
    initial_repos = #Fetch initial repos.
    {:ok, initial_repos}
  end

  def handle_call(:list_items, _from, state) do
    {:reply, state, state}
  end

  ## Helper functions
  def has_name?(actual_name, repo_name) do
    String.equivalent?(actual_name, repo_name)
  end
  # Other  helper functions to perform filtering by other criteria
   ....
end

Which approach is more favored in the elixir community?

Most Liked

al2o3cr

al2o3cr

The data structure you return from handle_call is copied back to the calling process. If state is large, this will make the second approach significantly more expensive to execute.

A third approach worth considering: have one handle_call that accepts a filter function:

def filter_by_name(pid, repo_name) do
  list_items(pid, fn repo -> has_name?(repo.name, repo_name) end)
end

def list_items(pid, filter \\ fn x -> x end) do
  GenServer.call(pid, {:list_items, filter})
end

def handle_call({:list_items, filter}, from, state) do
  {:reply, Enum.filter(state, filter), state}
end

This avoids copying state to the calling process by instead bringing filter to the data.

Where Next?

Popular in Questions Top

Tee
can someone please explain to me how Enum.reduce works with maps
New
lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
ycv005
I have followed this StackOverflow post to install the specific version of Erlang. And When I am running mix ecto.setup then getting fol...
New
freewebwithme
Using vs code and installed ElixirLS: support and debugger. And I got an error popped up on start up says Failed to run ‘elixir’ comma...
New
aadeshere1
I have a another noob question about loop. Since elixir is immutable, while loop is not directly possible. total = 10 while total != 0 ...
New
mathew4509
I have a list say x = ["23gh", "56kh", "97mh"] I would like to pass each element to Val in each iteration. Say, in iteration 1 -------...
New
WestKeys
Currently suffering from paralysis by [HTTP client] analysis. This is rather unusual in Elixirland as there tends to be consensus on the ...
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID<0.412.0> terminating ** (Postgrex.Error) FATAL...
New
jay1
Why is it that the mnesia database isn’t the most preferred database for use in Elixir/Phoenix?
New
idi527
I’ve been re-reading swift book again and noticed that multiline strings there don’t have a trailing line break, unlike in elixir iex(2)...
New

Other popular topics Top

yurko
Here are few pieces of (common) Linux knowledge that we use for reasonably small one server apps. We use Ubuntu but this should work for ...
New
Tee
can someone please explain to me how Enum.reduce works with maps
New
chrismccord
This release brings a number of exciting features, including integration with the new Phoenix LiveDashboard and Phoenix LiveView. There h...
New
script
If I have a string “1000 cfu/ml” . I want to remove the characters and / and space . So the string is like this "1000" What is the ...
New
vac
Hi, I'm quite new in Elixir and I'm trying to format a string to a PEM format. I have the certificate value like MIIDBTCCAe2...... and ...
New
freewebwithme
Using vs code and installed ElixirLS: support and debugger. And I got an error popped up on start up says Failed to run ‘elixir’ comma...
New
chensan
I have a User schema with a :from_id field set to type :string: defmodule TweetBot.Repo.Migrations.CreateUsers do use Ecto.Migration ...
New
msaraiva
Surface is an experimental library built on top of Phoenix LiveView and its new LiveComponent API that aims to provide a more declarative...
564 42633 214
New
ovidiubadita
Hey all, I discovered Elixir and I love it. I always wanted to learn a functional programming and I intended to go for Haskell, but afte...
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New

We're in Beta

About us Mission Statement